Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Inconsistent use of derivative vs derivatives #1118

Open
jeffersoncasimir opened this issue Apr 26, 2024 · 0 comments
Open

[python] Inconsistent use of derivative vs derivatives #1118

jeffersoncasimir opened this issue Apr 26, 2024 · 0 comments
Assignees
Labels
26.0-bug BIDS import pipeline Issues regarding the BIDS import pipeline

Comments

@jeffersoncasimir
Copy link
Contributor

jeffersoncasimir commented Apr 26, 2024

There are multiple locations where derivatives is used in place of derivative, which is the correct usage according to the BIDS spec.

This was discovered while testing with RB data, where the physiological_output_type is set to be derivatives. It breaks in one location when running without the -t set to either derivative or derivatives, and only with RB data since the regular Loris DB's physiological_output_type field doesn't include the s when initially added.

It would break more seriously if the -t parameter is set to either variation.

The fix on the Loris-MRI side is to change derivatives to derivative in all string comparisons in all files under python/.

Found when testing #1078.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26.0-bug BIDS import pipeline Issues regarding the BIDS import pipeline
Projects
None yet
Development

No branches or pull requests

1 participant