Casings - Prevent casings from sinking below terrain level #9711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnb432
reviewed
Jan 4, 2024
| private _lisPos = (lineIntersectsSurfaces [_pos, _pos vectorAdd [0,0,-1e11], objNull, objNull, true, 1, "ROADWAY", "FIRE"]) select 0; | ||
| private _casingPos = (_lisPos select 0) vectorAdd [0,0,0.005]; | ||
| if (((ASLtoATL _casingPos) select 2) < 0) then { // prevent casings sinking into the terrain | ||
| _casingPos set [2, _unitPos select 2]; |
There was a problem hiding this comment.
What about using getTerrainHeightASL instead of the unit's position's z component? I'm not sure if it's compatible with changes done by setTerrainHeight, but I feel it would be more accurate, as I have doubts your solution works well in uneven terrain.
Btw, does this currently account for being in buildings? I imagine so, but I just want to be sure.
There was a problem hiding this comment.
Buildings?
Yes. Only change is preventing a negative Z component in relation to the terrain.
getTerrainHeightASL
Didn't know that existed, good to know.
There was a problem hiding this comment.
I tested with _casingPos set [2, (getTerrainHeightASL _casingPos) vectorAdd [0,0,0.005]];, but it didn't yield good results.
Dystopian
reviewed
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.