Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iFrame test is broken #197

Open
Niek opened this issue Aug 16, 2022 · 1 comment
Open

iFrame test is broken #197

Niek opened this issue Aug 16, 2022 · 1 comment
Assignees
Labels
unexpected unexpected behavior in browsers

Comments

@Niek
Copy link
Contributor

Niek commented Aug 16, 2022

See: https://abrahamjuliot.github.io/creepjs/tests/iframes.html - the page load hangs because this URL is unreachable:

const webapp = 'https://script.google.com/macros/s/AKfycbw26MLaK1PwIGzUiStwweOeVfl-sEmIxFIs5Ax7LMoP1Cuw-s0llN-aJYS7F8vxQuVG-A/exec'

It would also be good to add an AbortController() to the fetch request (or any fetch requests, really), like this: https://dmitripavlutin.com/timeout-fetch-request/#2-timeout-a-fetch-request
Or the new approach using an AbortSignal: https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal/timeout

@abrahamjuliot abrahamjuliot self-assigned this Aug 16, 2022
@abrahamjuliot abrahamjuliot added the unexpected unexpected behavior in browsers label Aug 16, 2022
@abrahamjuliot
Copy link
Owner

abrahamjuliot commented Aug 16, 2022

Hey Niek, thank you for reporting this.

I plan to host the JSON on GitHub pages and add fetch timeouts. Apps Script is a nice way to manage cron jobs and use is free, but it's too slow if web traffic increases.


  • host JSON on GH pages
  • add fetch timeouts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unexpected unexpected behavior in browsers
Projects
None yet
Development

No branches or pull requests

2 participants