Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate RegionKey for rsID lookups #1

Open
abought opened this issue Jun 30, 2020 · 0 comments
Open

Investigate RegionKey for rsID lookups #1

abought opened this issue Jun 30, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@abought
Copy link
Owner

abought commented Jun 30, 2020

h/t @weinstockj

The current rsID lookup feature is based on a somewhat intricate internal structure of position: {refalt: rsid}. We might be able to simplify internals (and serialization) with a clever approach called VariantKey.

Items to evaluate:

  • Performance
  • Storage space used
  • Conceptual readability of code
  • Preservation of internal sort order (for efficient use of LMDB cache)

https://github.com/Genomicsplc/variantkey
@abought abought added the enhancement New feature or request label Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abought