Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github.com/ugorji/go/codec dependency (July 2019 > May 2021) #342

Closed
QuintinWillison opened this issue Jul 7, 2021 · 2 comments · Fixed by #506
Closed

Update github.com/ugorji/go/codec dependency (July 2019 > May 2021) #342

QuintinWillison opened this issue Jul 7, 2021 · 2 comments · Fixed by #506
Assignees
@mohyour
Milestone
Post-1.2.0 releas...

Comments

@QuintinWillison
Copy link
Contributor

QuintinWillison commented Jul 7, 2021 •
edited by sync-by-unito bot

We're requiring v1.1.7 but the latest version is v1.2.6.

┆Issue is synchronized with this Jira Task by Unito
@Rosalita
Copy link
Contributor

This package now appears to be at https://github.com/ugorji/go and the latest version is 1.2.7 Looking back through release notes there's a number of performance improvements and no obvious reason not to upgrade. We should however do some regression testing to check that things still work as expected after updating this dependency.

mohyour added a commit that referenced this issue May 11, 2022
@mohyour
#342 - update codec dependency
6b0a263
@mohyour mohyour mentioned this issue May 11, 2022
Merged
mohyour added a commit that referenced this issue May 12, 2022
@mohyour
Merge pull request #506 from ably/update/update-codec-dependency
67d703a 
#342 - update codec dependency
@mohyour mohyour mentioned this issue May 12, 2022
Open
@mohyour
Copy link
Contributor

mohyour commented May 12, 2022

Update was done to v1.1.9 as noted in #506. New issue - #511 created to update to the latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohyour mohyour

Labels
None yet
Milestone
Post-1.2.0 release cleanup
Development

Successfully merging a pull request may close this issue.

#342 - update codec dependency ably/ably-go
3 participants
@QuintinWillison @Rosalita @mohyour