Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor vault.py #90

Open
mzfr opened this issue Jan 3, 2019 · 2 comments
Open

Refactor vault.py #90

mzfr opened this issue Jan 3, 2019 · 2 comments
Assignees
Labels
good first issue Good for newcomers kwoc

Comments

@mzfr
Copy link
Collaborator

mzfr commented Jan 3, 2019

Currently, we have around 1200 lines of code in a single file which is probably not a good practice. Also, this will increase since we are going to continue to add more functions. So it would be good if we can move the functions out of the vault.py file and only keep it as an entry point and maybe perform basic checks on ip/url.

To call other functions we can have maybe a util directory where we can keep all the existing functions. This will increase the number of imports or number of files but it will definitely help us to keep everything clean in vault.py

@abhisharma404
Copy link
Owner

@mzfr I was thinking about the same issue. I think it is a great idea, it will also be more easier to configure Travis later on.

@mzfr mzfr added the good first issue Good for newcomers label Jun 1, 2019
@mzfr mzfr added the kwoc label Dec 3, 2019
@raajtilaksarma
Copy link

Hi, found this in KWOC. Would like to try to refactor it. But need some context on how to group functions (like which functions can be grouped into a module and then be imported into vault.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kwoc
Projects
None yet
Development

No branches or pull requests

3 participants