Is there a way of replacing the logging formatter?

[EpicBirb]

As the title says

Refer to this: https://docs.python.org/3/library/logging.html#logging.Formatter

[abhinavsingh]

@EpicBirb Yes. You can either:

1. Pass custom --log-format argument to proxy instance
2. Write a on_access_log handler in your plugin which does all the logging for you. Your handler can return None as context which will disable core logging.

[EpicBirb]

for the second solution. is it possible to fetch if the context from on_access_log is either an info, error, critical, warn, or debug?

because all i really want to do is modify 2022-10-31 16:47:50,632 - pid:26428 [I] pool.shutdown:125 - Shutting down 16 acceptors to have some color so that my eyes would feel better to identify if its an error or an info because its a huge pain

[abhinavsingh]

Of-course, [I] you see in logs is the log level.

I = INFO

[EpicBirb]

ok here let me reword this:

is there any way that i can modify the logs:
example:

2022-11-01 15:57:27,227 - pid:15424 [I] handler.handle_data:179 - HttpProtocolException: ProxyAuthenticationFailed

to

\n 2022-11-01 15:57:27,227 - pid:15424 [I] handler.handle_data:179 - HttpProtocolException: ProxyAuthenticationFailed

depending on what it is logging like info, error, etc
i can modify it based on that

\s 2022-11-01 15:57:27,227 - pid:15424 [E] handler.handle_data:179 - HttpProtocolException: ProxyAuthenticationFailed
\n 2022-11-01 15:57:27,227 - pid:15424 [I] handler.handle_data:179 - HttpProtocolException: ProxyAuthenticationFailed
\r 2022-11-01 15:57:27,227 - pid:15424 [D] handler.handle_data:179 - HttpProtocolException: ProxyAuthenticationFailed

[abhinavsingh]

As I explained it's very much possible. You can take inspiration from ProgramNamePlugin which adds updates client_ip with detected program name in the context. https://github.com/abhinavsingh/proxy.py/blob/develop/proxy/plugin/program_name.py#L64

You can add your own keys too. Those keys are then available within your log format.

You can also return None from your on_access_log callback which will disable internal logging. You can then log whatever you want using the information in context variable or elsewhere in your program.

Best

[abhinavsingh]

Please check https://github.com/abhinavsingh/proxy.py#oserror-when-wrapping-client-for-tls-interception

[abhinavsingh]

You must also provide more context to help reproduce the error. E.g. what exactly was tried.

[EpicBirb]

this isint exactly an issue, i just need to make an error to say that errors wont be passed though on_access_log

if you still want to reproduce this, enable end to end encryption and connect to the proxy using http (without the s)

[abhinavsingh]

No, access_log is not an exception handler :). No traceback or errors are passed to it currently. Thank you for confirming that it works as expected

[EpicBirb]

welp that sucks