Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch user profile #3

Open
aayush26 opened this issue Oct 1, 2017 · 9 comments
Open

Fetch user profile #3

aayush26 opened this issue Oct 1, 2017 · 9 comments
Assignees
Projects

Comments

@aayush26
Copy link
Owner

aayush26 commented Oct 1, 2017

Given username, this API should be able to fetch the user profile

Reference:
https://github.com/jayeshsolanki93/devgorant/blob/master/devrant.go#L65

@aayush26 aayush26 self-assigned this Oct 2, 2017
@coolq1000
Copy link
Collaborator

coolq1000 commented Oct 5, 2017

I'll get this one done 😄
EDIT
After I learn how this API works :P

@aayush26
Copy link
Owner Author

aayush26 commented Oct 5, 2017

cool. I will send an invite link to add you as collaborator. Once you accept it, I can assign it to you. I was about to start on it. But, its ok, I can catch up with other issues.
All the best.
I have also mentioned a url above for reference. That can be helpful. Have a look into it.

@coolq1000
Copy link
Collaborator

Thanks, I've accepted the invite, ready to start helping! I'm not too concerned about getting it done, I've successfully implemented it in my own API.

Just as a note for the API in general, no offence, but it does feel a little over complicated, just my opinion. Still willing to help out, ready to roll.

@aayush26 aayush26 assigned coolq1000 and unassigned aayush26 Oct 5, 2017
@aayush26
Copy link
Owner Author

aayush26 commented Oct 5, 2017

@coolq1000 I know the API is super simple and just sending a string and get or post request is enough. And thanks for sharing your opinions. Its great to know everyone's opinion.

I started out with this repo with a vision to not just write codes so that it works, but also write quality codes, follow best standards and maximum test coverages. And also integrate with multiple services like we integrated Travis CI and Coveralls, to make a good quality maintained repo.

Since, this repo is super simple logically to implement, we all can get huge exposure and try out different things and learn from it.
In future, when building or contributing to huge repos, the practices used here can be helpful.
And I still agree we might do things wrongly here, but eventually we will grow and help each other by reviewing and commenting to be a better coder.
Thats for long term vision.

@coolq1000
Copy link
Collaborator

Ah, fair enough.
I think this will be a good learning experience for me, aswell.

Thanks for explaining!

@coolq1000
Copy link
Collaborator

@aayush26
Just letting you know that I'm currently busy with work atm, will be free soon, though.
Is there a way we can chat properly? Discord?

@aayush26
Copy link
Owner Author

aayush26 commented Oct 8, 2017

@coolq1000 I have sent invite request in gitter. We have a chat room to discuss there.

@aayush26
Copy link
Owner Author

aayush26 commented Nov 1, 2017

@coolq1000 Any updates?

@coolq1000
Copy link
Collaborator

@aayush26 hey, sorry I've been quite busy, do you have discord? I use that often and we might be able to discuss this further?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
pirant
Awaiting triage
Development

No branches or pull requests

2 participants