You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem statement: Seems like pirant is compatible to only py2.7 currently. We should make it compatible for 3.4 and above also.
Solution suggested: @AmiraliM suggested on using SIX package
Scope of implementation: Fix existing codebase to make it compatible for all python versions.
@Cogitri We need to recheck once again. @AmiraliM found out an instance were it fails.
In python 3, response.context returns bytes while in python 2.7, it returns string. Hence, json.loads() works in 2.7 but not in 3.4
Why this was not captured in tests because we only wrote Unit tests and all these external responses using request library are mocked, hence we missed it and all tests passed.
Problem statement: Seems like pirant is compatible to only py2.7 currently. We should make it compatible for 3.4 and above also.
Solution suggested: @AmiraliM suggested on using SIX package
Scope of implementation: Fix existing codebase to make it compatible for all python versions.
References:
SIX package: https://pythonhosted.org/six/
The text was updated successfully, but these errors were encountered: