Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landing Page created #71

Closed
wants to merge 1 commit into from
Closed

Landing Page created #71

wants to merge 1 commit into from

Conversation

raibove
Copy link

@raibove raibove commented Mar 30, 2019 •
edited

Created front-end with landing page

Checklist:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you successfully ran tests with your changes locally?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

Issues Solved

Fixes #60

@raibove
Add files via upload
7e2ec61 
Created front-end with landing page
@aashutoshrathi
Copy link
Owner

Hi! Thanks for PR.
Make sure you have checked points in PR Template correctly.

(Powered by GitMate.io)

aashutoshrathi
aashutoshrathi reviewed Mar 30, 2019
View reviewed changes
Copy link
Owner

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, Thanks for PR!
Can you post a screenshot too?

@raibove
Copy link
Author

raibove commented Mar 30, 2019

img.docx

Screenshot is in this file

aashutoshrathi
aashutoshrathi requested changes Mar 30, 2019
View reviewed changes
Copy link
Owner

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty much basic but will work.
Just do a few changes.

  • Use proper class names.
  • Indent CSS file using some tool.
  • Text on button should be visible

fi.html
@@ -0,0 +1,60 @@
<html>
<head>
<title>test_case_generator</title>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make title Testcase Generator

fi.html
<head>
<title>test_case_generator</title>
<meta name="viewport" content="initial-scale=1.0,width=device-width">
<link rel="stylesheet" href="gra.css">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make filename index.css

@weekly-digest weekly-digest bot mentioned this pull request Mar 31, 2019
Closed
@rossoskull
Copy link

@aashutoshrathi should we close this PR due to inactivity?

@aashutoshrathi
Copy link
Owner

Yeah!

@rossoskull rossoskull closed this May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashutoshrathi aashutoshrathi aashutoshrathi requested changes

Assignees
No one assigned
Labels
status/inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initiate WebApp's Frontend
3 participants
@raibove @aashutoshrathi @rossoskull