Fix OUI & Ports data #156
Open
Fix OUI & Ports data #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new format has the first two fields padded with spaces in addition to separation by tabs
fetch original IANA csv
|
@madmini, You may want to add @aaronjwood as a reviewer. |
i dont seem to have the permission to do that |
|
Pull request commits work perfect. Tested successfully in a local self build, even for SDK 34. Kudos to madmini. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155.
Wireshark removed the
manufandservicesfiles from their git repo which were used for MAC vendor/OUI resolution and port service name and description lookup, respectively. Fortunately, similar replacements are provided elsewhere.As discussed in #155, Wireshark now hosts a generated file very similar to
manufat https://www.wireshark.org/download/automated/data/manuf.The
servicescites the IANA's Service Name and Transport Protocol Port Number Registry as their original source, with permission from and acknowledgement to the IANA.I have added acknowledgements for both sources to the readme.
Sadly, both replacements do not support
Accept-Encoding: gzip,and progress tracking is somewhat broken for the OUI update (finishes when displaying ~33%) and does not work for the ports update.For this and other reasons, replacements hosted by GitHub or other CDNs would be preferable.