Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability in ImageSharp dependency #82

Open
madorjan opened this issue Mar 6, 2024 · 5 comments
Open

Vulnerability in ImageSharp dependency #82

madorjan opened this issue Mar 6, 2024 · 5 comments

Comments

@madorjan
Copy link

madorjan commented Mar 6, 2024

The currently used SixLabors.ImageSharp version has a vulnerability, which produces following compiler warning:
NU1903 Warning As Error: Package 'SixLabors.ImageSharp' 2.1.6 has a known high severity vulnerability, https://github.com/advisories/GHSA-65x7-c272-7g7r

SixLabors.ImageSharp should be updated to 3.1.3.

@hyazinthh
Copy link
Member

hyazinthh commented Mar 6, 2024

ImageSharp 3 has a less permissive license requiring payment for commercial projects IIRC. I'm not sure if this is an option for commercial projects using Aardvark.

https://github.com/SixLabors/ImageSharp/blob/main/LICENSE

@madorjan
Copy link
Author

madorjan commented Mar 6, 2024

According to the license text, indirect usage of ImageSharp falls under the Apache 2.0 license. If I understand this correctly, for commercial Aardvark users that don't use ImageSharp directly, no license changes should happen.

@hyazinthh
Copy link
Member

That's how I understand it as well. Back then we had some concerns, but I don't remember the details. It's probably fine as it is worded.

@hyazinthh hyazinthh transferred this issue from aardvark-platform/aardvark.rendering Mar 7, 2024
@hyazinthh
Copy link
Member

hyazinthh commented Mar 7, 2024

Apparently, they backported the fix and released 2.1.7. You should be able to use that without requiring a new Aardvark.Base version. Still, it might be a good idea to move to 3.X eventually.

Edit: ImageSharp 3.X only supports .NET >= 6

@madorjan
Copy link
Author

madorjan commented Mar 7, 2024

OK, then I think an update to 2.1.7 would bei sufficient 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants