Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComputeMD5Hash should compute md5 hash #72

Open
luithefirst opened this issue Feb 9, 2022 · 0 comments
Open

ComputeMD5Hash should compute md5 hash #72

luithefirst opened this issue Feb 9, 2022 · 0 comments

Comments

@luithefirst
Copy link
Member

We have changed all MD5 uses to SHA1 since there were issues when running in WASM.

This was done in a quick hack and we should review this. It seems that there were only two uses, one in Introspection and one in ArrayExtensions (ComputeMD5Hash). I think ComputeMD5Hash should still calculate MD5 hashes as before and since this is a utility method I would see the responsibility on the user side. ComputeMD5Hash is rarely used in all Aardvark libraries (1 in Base, 0 uses in Rendering), and if so we could change it in the relevant places, e.g. in String.ToGuid() which we should change to SHA1 there and also update all comments accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant