Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No colors on diff viewer #93

Open
sylveon opened this issue Oct 29, 2017 · 4 comments
Open

No colors on diff viewer #93

sylveon opened this issue Oct 29, 2017 · 4 comments

Comments

@sylveon
Copy link

sylveon commented Oct 29, 2017

image

@Sergio0694
Copy link
Collaborator

@aalok05 Since that's basically a chunk of source code anyways, can't you just use the same API we're already using to get the syntax highlight HTML to display when opening a code file?

@aalok05
Copy link
Owner

aalok05 commented Oct 30, 2017

That's a good idea, however some logic has to be written to color the lines starting with + or -

@sylveon
Copy link
Author

sylveon commented Oct 30, 2017

Isn't it just possible to use the diff syntax highlighting scheme?
Eg:

@@ -52,17 +52,6 @@ struct WINCOMPATTRDATA
// Unchanged code
- // Deleted line
+ // Added line

@aalok05
Copy link
Owner

aalok05 commented Oct 30, 2017

@sylveon This scheme is not yet supported in MarkdownTextblock of UWP community toolkit, which is what we are using. We'll have to create a custom control for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants