Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Better handling of local media #13

Open
drinfernoo opened this issue Mar 21, 2019 · 3 comments
Open

[Feature Request] Better handling of local media #13

drinfernoo opened this issue Mar 21, 2019 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@drinfernoo
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
There are two inconsistencies regarding the handling of local media via OpenMeta. First of all, if we try to play media from OpenMeta that is already contained in the users' library, OpenMeta will still prompt to pick an add-on to play with. Secondly, when syncing Trakt to the local library, duplicates aren't ignored.

Describe the solution you'd like
The preference would be to have local content take obvious priority over remote content, with local content being played before trying to pick an add-on, and new Trakt content not being synced if it already exists in the local library.

@drinfernoo drinfernoo added the enhancement New feature or request label Mar 21, 2019
@drinfernoo drinfernoo added this to the 2.0 milestone Mar 21, 2019
@mriksman
Copy link

mriksman commented May 8, 2019

This is where I am totally confused. I haven’t seen a configuration guide on how to correctly manage local content and addon content (.strm files).

Right now, I have my library set up as
OpenMeta TV Shows
Local TV Shows
When I download/add a local TV Show (day a *.mkv file) I see a duplicate (the .strm from OpenMeta library and the .mkv from my local library). If I update library in OpenMeta, it removes the .strm file from the library and thus the duplicate is removed. But this seems ‘backwards’, and it’s a shame that until a library update is performed in OpenMeta, I see a duplicate.

I see on the OpenMeta ‘How to Write a Players File’ that there are Players files for ‘Kodi Library’ and ‘Local Files’ in the examples. What is the best way to use these?

So - should I only have ‘OpenMeta TV Shows’ listed in the Kodi Library, and let OpenMeta pick up the local files using the ‘Local Players’ file?
And how does the ‘Kodi Library’ Player work? Because if OpenMeta is the only source listed in the Kodi Library, then what would this Player serve/do? Seems like a circular reference...

Lastly, for the widgets on the Home screen, can I just use the normal Kodi shortcuts like ‘Recently added’, etc? I’ve seen some mention that we should be using the ‘Skin Helper Service Widget’, but I don’t know what benefits it provides?

Thanks for your time.

@mriksman
Copy link

I think the current TV Shows lib_tvshows.py works well - it checks the local library, and if it finds it stored locally it deletes the stream;

if delete or (season_num, episode_num) in libepisodes:
				if library_tv_remove_strm(show, show_folder, id, season_num, episode_num):
					clean_needed = True
			else:
				library_tv_strm(show, show_folder, id, season_num, episode_num)

However, the lib_movies.py does not have this feature. Hence I have duplicate Movies, but not TV Shows.

I think once this is fixed/added, local content and integration would work well - with no duplicates. I think this is better than using a Local Player file, as when I finally got it working, all local files looked the same as .strm files in the Library view (they had WEB for the resolution, whereas local content would normally have SD or HD).

@ghost
Copy link

ghost commented Aug 23, 2019

Have you taken a look at Venom's integration for some ideas?

  • Better duplication handling
    • I've never had to refresh to remove duplicates
  • Folders have actual names instead of IMDB IDs
    • Looks cleaner and easier to manage
  • Files are played correctly
    • Local files play as they should, strm files are scraped via Venom.

Regarding duplication, I have some questions/theories. (It's really late and I haven't thoroughly looked into these myself.)

  • Could using IMDB IDs instead of proper names be part of the issue?
  • Could OpenMeta be initially searching it's own created sources for duplicates, adding the files since there are none, and later removing the files it added after reading the other sources and finding out it had created duplicates.
  • Or a mix of both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants