The Oath player is not working #54
Comments
|
What's changed? It's very hard to tell the difference by looking at a wall of code 😬 |
|
I'll try to post a file once I'm home. Basically using just "&" rather than I didn't dig deeper into the "why". |
|
In that case, it depends on what URL encoding/decoding the add-on is using. I'll need to test one way vs. the other. |
Great, thanks. |
Has this been tested and added to the player file zip download? I'm guessing probably not. I found I had a problem with The Oath's player file in Kodi v19, but only on my LibreElec device. My Windows and Android devices continued to work normally. In any case from @fedevx 's posts above I made up a new player file as follows which works on all my devices. The only issue I'm having is that I'm no longer getting progress marked in TMDBH if I stop a video before the end. I did have that working perfectly on Kodi v18. But I'm not quite sure where the issue with that is though since it's happened since updating to Kodi v19, and both The Oath and TMDBH have updated to Python 3 too. Any thoughts regarding this? THANKS :) |
|
The Oath must need some value passed through the player URI in order to be able to mark progress correctly. Really, TMDbHelper has no control over it, as the add-on that ends up playing the content is what actually marks the item as watched. Honestly, I don't use The Oath, or really TMDbHelper anymore either... If the above player file is working, I'd be happy to merge it into this package, but I can also wait until whatever is wrong with it gets fixed. |
|
If I understand correctly from reading the various issues and jurial's repsonses then Resume points are saved by Kodi itself, not TMDBH or the addon (well addons can do it too, but that's another story). And if I further understand correctly player files for addons that 'any addon that scrapes sources should have is_resolvable set to false (i.e. set it to PlayMedia NOT setResolvedUrl). Then TMDBH uses it's Settings > Expert > Reroute PlayMedia to call xbmc.Player() directly to send the Resume point. Or am I mistaken? I not an expert in this regard. In my case though the Resume points don't appear to be saved by Kodi anymore since updating to v19. I no longer get the Resume indicator in TMDBH episode lists. (it does work in YouTube though, so it's not an overall Kodi problem). Really, I'm not even sure if this is working in Kodi v19 & TMDBH in the first place. Maybe it's broken and I need to raise an issue over on TMDBH. Regarding the above player file, yes it is working on the 3 devices that I have to test it on: LibreElec, Windows, and Android. But what do you mean by "I can also wait until whatever is wrong with it gets fixed." ? Is there something wrong in The Oath that should be addressed? The developer is very responsive on GitHub. As I mentioned, personally I only had problems on LibreElec, which to me indicated an LE/Kodi issue after updating to v19, possibly with reading the player file correctly ( "&" rather than "&" for the parameters, as @fedevx mentioned) rather than an issue with The Oath itself? But again, I'm not an expert. THANKS good doctor :) |
|
Kodi does save resume points for library items, but that doesn't work for most add-ons. The In almost every case of this, the add-on that is doing the playback needs to mark progress on Trakt.tv, which then TMDbHelper can read back from the website. I meant if you're able to get the player to a state where marking resume points works. |
|
Hello, |
The patch I posted still works if you want to give that a try. Still, would be great if this could be officially fixed. |
Perfect!In case, it is not forbidden, here the changes for several addons in the LibreELEC Matrix for TMDB, which works with the changes made by fedevx. Change to Kodi \ addons \ plugin.video.themoviedb.helper \ resources \ players .zip. Thanks, to solve the problem! Have a good day! |
Hi, for the matrix in tmdb helper, I recreated for the addons players I use them. Asgard and Q Cuantumm I don't have RD access, the others I use. In case you see them good, you can update in a4k. https://bit.ly/3k9KpOQ .Good day! |
As per the subject, same for Movies or Series. After selecting the player, it just hangs. What gets it working for me is using the below for direct.theoath.json:
{ "name" : "[COLOR orange]The Oath[/COLOR]", "plugin" : "plugin.video.theoath", "priority" : 500, "play_movie" : "plugin://plugin.video.theoath/?action=play&title={title_+}&year={year}&imdb={imdb}&meta=%7B%22rating%22%3A+%22%22%2C+%22code%22%3A+%22{imdb}%22%2C+%22tmdb%22%3A+%22{id}%22%2C+%22imdb%22%3A+%22{imdb}%22%2C+%22year%22%3A+%22{year}%22%2C+%22duration%22%3A+%22%22%2C+%22plot%22%3A+%22{plot}%22%2C+%22votes%22%3A+%22%22%2C+%22title%22%3A+%22{title_+}%22%2C+%22fanart%22%3A+%22{fanart}%22%2C+%22tagline%22%3A+%22%22%2C+%22writer%22%3A+%22%22%2C+%22next%22%3A+%22%22%2C+%22poster%22%3A+%22{poster}%22%2C+%22mediatype%22%3A+%22movie%22%2C+%22director%22%3A+%22%22%2C+%22studio%22%3A+%22%22%2C+%22genre%22%3A+%22%22%2C+%22metacache%22%3A+true%2C+%22premiered%22%3A+%22{premiered}%22%2C+%22originaltitle%22%3A+%22{title_+}%22%2C+%22cast%22%3A+%5B%5B%22%22%5D%5D%2C+%22mpaa%22%3A+%22%22%2C+%22trailer%22%3A+%22plugin%3A%2F%2Fplugin.video.theoath%2F%3Faction%3Dtrailer%26name%3D{title_+}%2B%2528{year}%2529%22%7D&t={now}", "play_episode" : "plugin://plugin.video.theoath/?action=play&title={title_+}&year={year}&imdb={imdb}&tvdb={id}&season={season}&episode={episode}&tvshowtitle={clearname_+}&premiered={firstaired}&meta=%7B%22rating%22%3A+%22%22%2C+%22code%22%3A+%22{imdb}%22%2C+%22tmdb%22%3A+{tmdb}%2C+%22imdb%22%3A+%22{imdb}%22%2C+%22year%22%3A+%22{year}%22%2C+%22duration%22%3A+%22%22%2C+%22plot%22%3A+%22{plot}%22%2C+%22votes%22%3A+%22%22%2C+%22thumb%22%3A+%22{thumbnail}%22%2C+%22title%22%3A+%22{title_+}%22%2C+%22tvdb%22%3A+%22{id}%22%2C+%22label%22%3A+%22{title_+}%22%2C+%22season%22%3A+%22{season}%22%2C+%22status%22%3A+%22%22%2C+%22poster%22%3A+%22{poster}%22%2C+%22tvshowtitle%22%3A+%22{clearname_+}%22%2C+%22mediatype%22%3A+%22episode%22%2C+%22studio%22%3A+%22%22%2C+%22genre%22%3A+%22%22%2C+%22banner%22%3A+%22{thumbnail}%22%2C+%22episode%22%3A+%22{episode}%22%2C+%22premiered%22%3A+%22{firstaired}%22%2C+%22fanart%22%3A+%22{fanart}%22%2C+%22trailer%22%3A+%22plugin%3A%2F%2Fplugin.video.theoath%2F%3Faction%3Dtrailer%26name%3D{clearname_+}%22%7D&t={now}" }The text was updated successfully, but these errors were encountered: