Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the level of the rule directly on the item listed #1209

Open
aguscha333 opened this issue Mar 12, 2021 · 7 comments · May be fixed by #1270
Open

Add the level of the rule directly on the item listed #1209

aguscha333 opened this issue Mar 12, 2021 · 7 comments · May be fixed by #1270
Assignees
Labels
checklist Updates for the web accessibility checklist data Issues with content sourced from JSON data files.

Comments

@aguscha333
Copy link

aguscha333 commented Mar 12, 2021

Please review our Contributing guidelines:
https://a11yproject.com/contributing-guidelines/

Summary

I think it would be useful to be able to quickly see the level of accessibility (A, AA, or AAA) of every item on the accessibility checklist. Ideally, a webpage should be able to check them all off but it is also important to know what to prioritize to make the most impact sooner.

Expected result

Show the level (A, AA, or AAA) on each item in the accessibility checklist when the items are either collapsed or not.

Actual result

This is not available yet.

I would like to know if you think this is a good idea and how possible its implementation is as well. With some guidance, I'd be happy to take a crack at it.

@boring-cyborg
Copy link

boring-cyborg bot commented Mar 12, 2021

Thanks for opening your first Issue! Please make sure you've read our Code of Conduct and Contributing guidelines.

@ericwbailey
Copy link
Member

Hey @aguscha333, I think this is a lovely idea! Some of the checklist items represent multiple WCAG success criterion, so this might get a little tricky. Do you think it'd be an average, or the highest applicable level?

As for implementation, here's where the checklist content is stored. We could add a wcag entry for the JSON data, then update the checklist partial to output it.

@ericwbailey ericwbailey added checklist Updates for the web accessibility checklist data Issues with content sourced from JSON data files. labels Mar 16, 2021
@aguscha333
Copy link
Author

Hmm good question, I was not expecting them to relate to more than one level. I think if we are only showing one level I would show the lowest applicable level since it's the first level that people are going to try to cover so listing the highest one only could lead to the item being dismissed and left to do later. That being said, since there are only 3 levels I think that it could be possible to list them all like A, AA for example.

In case I want to contribute and add the change myself, I would need a bit of guidance in gathering the levels associated with each item in the checklist JSON. Each item has a "wcag" property that has the name of the guideline and then also a link. I haven't checked all of them but it would just be to open the link and copy the levels listed there?

I would add a property called wcagLevels and for simplicity the value could be just a string like "A, AA" or it could be an array like ["A", "AA"] and then parsed some how. What do you think?

@resource11
Copy link

resource11 commented Mar 18, 2021

I can take a crack at this, @ericwbailey or @aguscha333, if you want.

@ericwbailey
Copy link
Member

ericwbailey commented Mar 19, 2021

I think if we are only showing one level I would show the lowest applicable level since it's the first level that people are going to try to cover so listing the highest one only could lead to the item being dismissed and left to do later.

This makes sense to me!

In case I want to contribute and add the change myself, I would need a bit of guidance in gathering the levels associated with each item in the checklist JSON.

@resource11: Is this something you'd be comfortable helping out with?

I haven't checked all of them but it would just be to open the link and copy the levels listed there?

Sounds like a perfectly reasonable starting point to me 🙂

I would add a property called wcagLevels and for simplicity the value could be just a string like "A, AA" or it could be an array like ["A", "AA"] and then parsed some how. What do you think?

That sounds like a good approach. I think a string should be sufficient for now, I don't anticipate needing an array for anything fancy down the line.

@resource11
Copy link

I'm comfortable helping out with this one, @ericwbailey!

@aguscha333
Copy link
Author

aguscha333 commented May 9, 2021

Hey @resource11 did you get a chance to work on this? if not maybe I could try implementing it?

@aguscha333 aguscha333 linked a pull request May 9, 2021 that will close this issue
@mxmason mxmason linked a pull request May 9, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checklist Updates for the web accessibility checklist data Issues with content sourced from JSON data files.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants