Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Grass blacklist to use tags instead of mod id for better filtering #309

Open
ffuentesm opened this issue Dec 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ffuentesm
Copy link

Is your feature request related to a problem? Please describe.
I use different compact mods that add different tools of other mod materials, so a single mod adds knives, and swords, the current method of swinging through grass uses a mod id which causes all items of that mod to be affected.

Describe the solution you'd like
Would be easier if the blacklist was made via item tag, so forge:tool/knife or forge:tool/scavaging so the items with those tags wodl break grass while anything else would ignore it.

@ZsoltMolnarrr ZsoltMolnarrr added the enhancement New feature or request label Dec 11, 2023
@ZsoltMolnarrr
Copy link
Owner

I don't know how this could be implemented without breaking existing configs.

Also, I am unsure about the performance of tag check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants