Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queueing attacks #125

Open
Hate9 opened this issue Oct 2, 2022 · 4 comments
Open

Queueing attacks #125

Hate9 opened this issue Oct 2, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@Hate9
Copy link

Hate9 commented Oct 2, 2022

I read project readme, checked client side and server side configurations, and no such feature exists - YES

Is your feature request related to a problem? Please describe.
I dislike hold-to-attack mode, but repeatedly clicking to attack, just so I happen to click when the cooldown is done.

Describe the solution you'd like
Easy solution: dark souls-like attack queueing. When you click, if you can't currently attack, it waits to attack until you can attack again, and then attacks! Ideally with a configurable maximum number of attacks queued at once.

Describe alternatives you've considered
I suppose you could make it so that holding down the button triggers an attack when the cooldown expires, if and only if the button has been released since the last attack was made. This seems like more fun, though.

@ZsoltMolnarrr ZsoltMolnarrr added the enhancement New feature or request label Oct 2, 2022
@ZsoltMolnarrr
Copy link
Owner

Hello!
I am not against this feature, however I am not interested implementing it either.
(This is an open source project, anyone is free to implement it, given the submitted code meets the quality standards.)

Please keep in mind the goal of the project is to replicate Minecraft Dungeons combat experience, not Dark Souls.

@Hate9
Copy link
Author

Hate9 commented Oct 6, 2022

That's fair (and I might try implementing it, though I don't have much modding experience), but for the record I'm not suggesting this because I want my minecraft to work like dark souls, I'm suggesting it because click-mode just isn't very fun, and hold-mode feels a little too easy.

@ZsoltMolnarrr
Copy link
Owner

ZsoltMolnarrr commented Oct 6, 2022

I consider no semantical difference between the two solutions.
The current implementation is close to Minecraft Dungeons, which is the project goal.
So in fact, I don't even really want to have any mechanic from dark souls, since I am not going to use it, hence I don't intend to maintain the feature.
So a PR would only be accepted if the change is very small and straightforward.

@neutralboolean
Copy link

Hold mode likely feels too easy because you can knock back an single mob without worry or thought. An simple solution would be to find a mod that reduces knockbacks from attacks or submit a PR to scale knockback based on the weapon used, so the heavier weapons knockback further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants