Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The github release asset for 1.36.33 cannot be built on its own. #3781

Open
Richard-Cranium opened this issue Nov 2, 2023 · 9 comments
Open
Milestone

Comments

@Richard-Cranium
Copy link

By "release asset", I mean the source archives available at https://github.com/ZoneMinder/zoneminder/releases/tag/1.36.33

This isn't a runtime issue, this is a "cannot possibly build using" issue. After downloading one of the release assets, un-zipping/tarring the source and changing to the resulting directory, the simple command "cmake ." fails with the earliest error message being...

CMake Error at CMakeLists.txt:13 (message):
The git submodules are not available. Please run git submodule update
--init --recursive

Whatever you are using to create the release assets is not providing anything that can be used to build anything. I'd prefer that you fix that so that those assets are actually useful, but I fear that you simply won't bother creating them any more.

Copy link

welcome bot commented Nov 2, 2023

Thanks for opening your first issue here! Just a reminder, this forum is for Bug Reports only. Be sure to follow the issue template!

@Richard-Cranium
Copy link
Author

Richard-Cranium commented Nov 2, 2023

Hi welcome bot! Your template is tightly focused for runtime issues and there is no indication of how someone could report a build issue!

@jp-bennett
Copy link
Contributor

Hi welcome bot! Your template is tightly focused for runtime issues and there is no indication of how someone could report a build issue!

There are intelligent humans behind the curtain. I would tend to agree that the release tarball should have the git submodules populated.

@SteveGilvarry
Copy link
Member

SteveGilvarry commented Nov 2, 2023 via email

@connortechnology
Copy link
Member

I wouldn't be opposed to doing away with the submodules. They are a frequent source of annoyance.

@Richard-Cranium
Copy link
Author

Historically it was not possible to alter the releases and include the submodule, probably a discussion in the issue history. But that is probably not the case with GitHub actions. Thanks for the heads up.

I don't expect you to fix the past; I simply hope that you'd fix the future or tell me that you cannot.

@Richard-Cranium
Copy link
Author

Richard-Cranium commented Nov 4, 2023

Hi welcome bot! Your template is tightly focused for runtime issues and there is no indication of how someone could report a build issue!

There are intelligent humans behind the curtain. I would tend to agree that the release tarball should have the git submodules populated.

There are semi-intelligent humans (despite my avatar and nick) in front of the curtain as well. It would have been churlish of me to vent any annoyance to the welcome bot.

EDIT: "have churlish" makes no sense. "have been churlish" might make sense.

@SteveGilvarry
Copy link
Member

SteveGilvarry commented Nov 4, 2023 via email

@Richard-Cranium
Copy link
Author

My nick here is self-proclaimed. My gmail username is earned. :D

@connortechnology connortechnology added this to the 1.38.0 milestone Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants