Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline/requirements for Ledger integration #30

Closed
Z2z123 opened this issue Oct 7, 2021 · 8 comments
Closed

Timeline/requirements for Ledger integration #30

Z2z123 opened this issue Oct 7, 2021 · 8 comments
Labels
question Further information is requested

Comments

@Z2z123
Copy link

Z2z123 commented Oct 7, 2021

Hi, are we still waiting on Ledger to integrate this? Is there a way to speed up the process such as if a desktop wallet supported the app?
Would much work be required to support Orchard/Unified addresses? I would say a grant from ZF or ZOMG would be easily supported once Sapling's running on Ledger.
Cheers

🔗 zboto Link

@jleni
Copy link
Member

jleni commented Feb 16, 2022

The problem is that nobody integrated the app in a web or desktop wallet and this was beyond our scope.

We have been discussing with ZF or ZOMG that we could actually integrate ourselves or even create a new wallet.

Without any integration of our app into a wallet, Ledger will never release.

@jleni jleni pinned this issue Feb 16, 2022
@jleni
Copy link
Member

jleni commented Feb 16, 2022

This app has been getting old and needs also some maintenance as this stage:

  • Upgrade SDKs
  • support orchard, etc.

We really put a lot of effort to get this working in Nano S. Actually, it was more like a challenge and a contribution to the community rather than something economically efficient. So we would also love this see this app in the wild being used by people!

@luckytokidoki
Copy link

luckytokidoki commented Mar 5, 2022

Zcash Community Grants would welcome any proposal to get this in the hands of user.

Btw any reason why issue 21 was completely ignored?

@jleni
Copy link
Member

jleni commented Mar 7, 2022

It has not been ignored, however, it is difficult for us to justify continuous attention and support of this app after so much time since the completion of our milestones (years?).

In the original discussion, we suggested and preferred to be in charge of the integration to be 100% we had control over that timeline too.

Thanks for your suggestion, we will definitely reach out and see how we can reboot this project. This means upgrading the project and taking over integration work so we can ensure that the project gets to users.

@hhanh00
Copy link

hhanh00 commented Mar 23, 2022

Hi @jleni, I have given a good effort to make this app run but unfortunately I have now run into a wall. The app cannot load anymore after a firmware upgrade. It seems to be just missing some small things.

Great work, it was clearly quite challenging.

@hhanh00
Copy link

hhanh00 commented Apr 25, 2022

FYI, I managed to use integrate it in Ywallet --> https://www.youtube.com/watch?v=IazybvQg68w

@jleni
Copy link
Member

jleni commented Apr 25, 2022

@luckytokidoki

Btw any reason why #21 was completely ignored?

It was not completely ignored. But our progress was stalled by the lack of ANY integration so it was impossible to submit to Ledger.

After >1yr of our milestone complete, we could not actively maintain things efficiently. I hope you understand we didn't have any maintenance contract. This GitHub issue was not even a bug itself.

More recently, a related improvement went here:

https://github.com/Zondax/ledger-zcash/pulls?q=is%3Apr+is%3Aclosed+label%3A%22fixes+nullifier+issue+%2321%22

We rebooted actively development of this app around 1 month ago as you can see in the project history.

@jleni
Copy link
Member

jleni commented Apr 25, 2022

Moreover, I hope you can see that we handled some the changes here:

This app has been getting old and needs also some maintenance as this stage:

Upgrade SDKs
support orchard, etc.
We really put a lot of effort to get this working in Nano S. Actually, it was more like a challenge and a contribution to the community rather than something economically efficient. So we would also love this see this app in the wild being used by people!

@jleni jleni added the question Further information is requested label Apr 25, 2022
@zboto zboto bot closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants