Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import issue in header files for v2.3.0+ with Carthage? #659

Open
asana-jau opened this issue Dec 1, 2022 · 0 comments
Open

Import issue in header files for v2.3.0+ with Carthage? #659

asana-jau opened this issue Dec 1, 2022 · 0 comments

Comments

@asana-jau
Copy link

asana-jau commented Dec 1, 2022

Steps to reproduce

  1. Currently our app compiles with ZipArchive/ZipArchive "v2.2.3"
  2. I tried upgrading the Carthage dependency to "v2.3.0" OR "v2.4.0"
  3. App fails to compile with the following 2 errors:

'SSZipArchive.h' file not found with brackets; use "quotes" instead
'SSZipCommon.h' file not found with brackets; use "quotes" instead

v2 3 0

  1. Manually converting the #import <SSZipArchive.h> to #import "SSZipArchive.h" and #import <SSZipCommon.h> to #import "SSZipCommon.h" indeed makes the app compile

Expected behavior

App should compile without having to edit the checked-out Carthage files

Actual behavior

App does not compile; we have to manually edit the checked-out Carthage files, which is not feasible considering the checked-out Carthage files is (understandably) git-ignored

Version of ZipArchive

v2.3.0+

Environmental information

Lmk what will be helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant