Pull z perf into z2 so that we can run performance tests against zq2 #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrw-zilliqa
force-pushed
the
users/richard/866_perf_test
branch
2 times, most recently
from
19ce57a
to
c62d72a
Compare
[feat] Reuse old network configurations.
(fix) there is now a new release of zilliqa-rs that we can depend on. (fix) allow us (hopefully!) to depend on zilliqa github repos.
rrw-zilliqa
force-pushed
the
users/richard/866_perf_test
branch
from
c62d72a
to
8f37227
Compare
mauromedda
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly tongue-in-cheek PR and mainly here for separability. This PR brings in z perf. However, it doesn't work yet - I get errors from the
lots.yamltest.Sadly, recent changes to zq2 mean that otterscan fails to load into the browser against it, so I am now going to fix that and come back to the bugs in the actual performance tests.
I don't want to come back later with a really big PR, so I'm filing this one now - feel free to say now and I'll close and reopen later when it actually works .. I should also pin the version of zilliqa-rs once we have released the current set of API changes.
Closes #866
(PS probably not worth more than a quick run-through until Clippy is happy - sorry - failed to check before hitting the build PR button)