Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockNumber parameters in Eth APIs do not respect two-chain finalisation #863

Open
JamesHinshelwood opened this issue Apr 24, 2024 · 0 comments
Open

BlockNumber parameters in Eth APIs do not respect two-chain finalisation #863

JamesHinshelwood opened this issue Apr 24, 2024 · 0 comments
Labels
area:apis Related to externally-facing APIs bug Something isn't working

Comments

@JamesHinshelwood
Copy link
Contributor

Currently if you pass "finalized" or "safe" for the block number, we just take the block 2 steps away from the latest. This isn't correct.

zq2/zilliqa/src/node.rs

Line 288 in 3b3e398

// todo: this doesn't respect two-chain finalization

@JamesHinshelwood JamesHinshelwood added bug Something isn't working area:apis Related to externally-facing APIs labels Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:apis Related to externally-facing APIs bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JamesHinshelwood