Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reverted transaction handling #591

Open
2 tasks
theo-zil opened this issue Dec 1, 2023 · 1 comment
Open
2 tasks

Fix reverted transaction handling #591

theo-zil opened this issue Dec 1, 2023 · 1 comment

Comments

@theo-zil
Copy link
Contributor

theo-zil commented Dec 1, 2023

  • Ensure gas is charged even if the transaction is reverted. Currently the gas fee is bundled with all the other applys, and none of them are applied if the result wasn't a success.
  • Ensure touched_address_index is updated/not updated appropriately, especially in the case of a revert.
@JamesHinshelwood
Copy link
Contributor

@theo-zil Is this fixed now? I think the first bullet point is but the second might not be? Arguably I think we should still add entries to the touched_address_index in the case of a revert, since you probably still want to see those transactions in an explorer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamesHinshelwood @theo-zil