Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convergence results depend on diffuseRatio factor #58

Open
f1shel opened this issue Dec 17, 2021 · 0 comments
Open

Convergence results depend on diffuseRatio factor #58

f1shel opened this issue Dec 17, 2021 · 0 comments

Comments

@f1shel
Copy link

f1shel commented Dec 17, 2021

In DisneyBSDF.glsl:

float diffuseRatio = 0.5 * (1.0 - material.metallic);

The 0.5 here says we will 50% use cosineSampleHemisphere and 50% use use importanceSampleGGX. So, the 0.5 is a factor to determine multiple importance sampling strategy. If everything is right, the converge result should not vary from diffrent choices.

However, if you change diffuseRatio like,

float diffuseRatio = 0.08 * (1.0 - material.metallic);
float diffuseRatio = 0.1 * (1.0 - material.metallic);
float diffuseRatio = 0.5 * (1.0 - material.metallic);
float diffuseRatio = 0.8 * (1.0 - material.metallic);
...

you will get different rendering results (test scene is hyperion.scene, observable difference below the white sphere ).

1
2

Is it a bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant