New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Security group to VPC relationship missing #131

Open

varunjain99 opened this issue Mar 21, 2023 · 1 comment

Labels

bug

Contributor

varunjain99 commented Mar 21, 2023 •

edited

security group intel module runs before vpc

so https://github.com/Zeus-Labs/cartography/blob/master/cartography/intel/aws/ec2/security_groups.py#L119

this line here does not end up creating the relationship.

Impact is the asset inventory on UI won't show the VPC the security group is associated with.

Fix is to not just match the vpc node but to create it if it's not already in the neo4j database

varunjain99 added the bug label

Contributor Author

varunjain99 commented Mar 21, 2023

Likely same issue for (snet)-[r:MEMBER_OF_AWS_VPC]->(vpc) relationship between EC2Subnet and AWSVpc

Lumping the two into the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment