Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable localizations of UI #91

Open
tbeddy opened this issue Jul 16, 2017 · 3 comments
Open

Enable localizations of UI #91

tbeddy opened this issue Jul 16, 2017 · 3 comments

Comments

@tbeddy
Copy link
Contributor

tbeddy commented Jul 16, 2017

A user would have the option of changing the language of the game's UI through a dropdown with available languages.

@tbeddy
Copy link
Contributor Author

tbeddy commented Aug 28, 2017

@djwhitt The names of the units should be localized when shown in the unit picker, right? They aren't currently in the dict.

@tbeddy
Copy link
Contributor Author

tbeddy commented Sep 1, 2017

As I mentioned earlier, I'm using a dropdown for the user to select the language. It's currently in the upper right hand corner. (ALL CAPS is my test dict.)

dropdown

Would you prefer it be put somewhere else?
And should I replace it with a modal?

@tbeddy
Copy link
Contributor Author

tbeddy commented Sep 8, 2017

I have since implemented the modal and it definitely makes more sense. I'm thinking of labeling the link "Settings" instead of whatever the current language is, so other settings, like whether or not to show the "You still have turns left" modal, can go there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant