Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WallPaper Image #140

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WallPaper Image #140

wants to merge 1 commit into from

Conversation

y4my4my4m
Copy link
Collaborator

The basic implemlentation is done.
A few things to fix:

  • Start the DC start after the main menu so as to not overwrite it
  • Dynamically recognize the resolution and assign it to the proper folder
  • Hotkey change wallpaper
  • The uPNG lib is being reused in multiple apps now, would be nice to decide where to put it and make it globally available.

Screenshot_20231118_203115

@y4my4my4m y4my4my4m self-assigned this Nov 19, 2023
@y4my4my4m y4my4my4m linked an issue Nov 19, 2023 that may be closed by this pull request
@GutPuncher
Copy link
Contributor

The uPNG lib is being reused in multiple apps now, would be nice to decide where to put it and make it globally available.

The LICENSE of the uPNG lib is not compatible with Zeal's public domain license. A public domain / Creative Commons Zero / Zero-Clause BSD licensed PNG library implementation must be used for the library to be eligible to be merged to the OS repo. This could be done by finding one that has a compatible license, or to delete the existing library file(s) and begin reverse engineering a compatible-license PNG library from scratch. A simpler choice may be to instead make the software requiring a non-public-domain library to be a 'third-party' application, like ported emulators, living in its own separate repository at the Organization-level that can be optionally git cloned into Zeal's src/Home/ folder.

@GutPuncher GutPuncher marked this pull request as draft December 10, 2023 17:35
@y4my4my4m
Copy link
Collaborator Author

Good catch, I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting an image file as your wallpaper.
2 participants