Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove expressway styling from ramps #1017

Open
ZeLonewolf opened this issue Dec 23, 2023 · 2 comments
Open

Remove expressway styling from ramps #1017

ZeLonewolf opened this issue Dec 23, 2023 · 2 comments
Labels
bug Something isn't working openmaptiles A change is needed in OpenMapTiles to support this

Comments

@ZeLonewolf
Copy link
Owner

ZeLonewolf commented Dec 23, 2023 •
edited

At this location, some link roads have expressway tagging. While it's not wrong per se to tag this on highway=trunk_link and so forth, I don't think we should be styling them like expressways, because ramps have a singular characteristic.

image
@ZeLonewolf ZeLonewolf mentioned this issue Dec 23, 2023
Merged
@ZeLonewolf
Copy link
Owner Author

I'm working on a PR to fix this on the OpenMapTiles side, but it could also be encoded in the style.

@ZeLonewolf ZeLonewolf added bug Something isn't working openmaptiles A change is needed in OpenMapTiles to support this labels Dec 24, 2023
TomPohys pushed a commit to openmaptiles/openmaptiles that referenced this issue Dec 28, 2023
@ZeLonewolf
Remove expressway from ramps (#1602)
b9c9e69 
#1313 added `expressway` tagging to the transportation layer. However, this also added the `expressway` attributes to ramps where it doesn't make sense (ramps by definition are controlled-access roads in all cases).  This PR corrects this by dropping the `expressway` attribute from ramps where it doesn't make sense to do so.

See also ZeLonewolf/openstreetmap-americana#1017
@ZeLonewolf
Copy link
Owner Author

This is now corrected in OpenMapTiles, which will resolve this issue once it's picked up in planetiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working openmaptiles A change is needed in OpenMapTiles to support this
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ZeLonewolf