Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document guidance on hiding certain POI labels at lower zooms #1000

Open
claysmalley opened this issue Dec 5, 2023 · 1 comment
Open

Document guidance on hiding certain POI labels at lower zooms #1000

claysmalley opened this issue Dec 5, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation points of interest

Comments

@claysmalley
Copy link
Collaborator

claysmalley commented Dec 5, 2023

I think implementing text rendering at a higher zoom level than icons is a nice approach for a wide variety of icons, including here. Since it'll only become more important as more icons are added, it might make sense to decide on a style-wide guidance for when to do and not do it, rather than continuing on an ad-hoc basis (though I don't think that resolving such a discussion should block implementing it here)

Originally posted by @wmisener in #999 (comment)

@claysmalley claysmalley added documentation Improvements or additions to documentation points of interest labels Dec 5, 2023
@wmisener
Copy link
Contributor

wmisener commented Dec 7, 2023

For context, I think text is currently first rendered at a higher zoom than the symbol is for bus stops (icon appears at z15, label appears at z17) and gas stations (icon appears at z15, label appears at z16). I wonder if it makes sense for this to be extended to other "minor" POIs (cafes, bars, etc, for which text and icon currently appears at z16), or even more major ones (schools, places of worship, etc, which currently appear at z15).

Right now it's not too much of an issue, as icons are still pretty sparse. But as rendered features become more densely distributed, it might make sense to render some labels later for more features to avoid inconsistencies. It also provides another way to emphasize certain features by rendering their labels relatively early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation points of interest
Projects
None yet
Development

No branches or pull requests

2 participants