Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nx moving JS graph building to new location #286

Closed
AgentEnder opened this issue Mar 27, 2023 · 1 comment · May be fixed by #287
Closed

Nx moving JS graph building to new location #286

AgentEnder opened this issue Mar 27, 2023 · 1 comment · May be fixed by #287
Labels
bug Something isn't working

Comments

@AgentEnder
Copy link

Current Behavior

@nx-plus/vue doesn't use the plugin project graph API that was released in Nx 12.X, instead, it patches part of Nx's code on postinstall. The file that is patched is being renamed on Nx's side of things, so this will break either before v16 or at v16, depending on how we release our changes.

Expected Behavior

@nx-plus/vue uses the plugin project graph API, or at minimum adds the new path to the getPath function inside the patching code.
https://github.com/ZachJW34/nx-plus/blob/master/libs/vue/patch-nx-dep-graph.js#L28

Steps to Reproduce

  1. Check out the branch from feat(core): refactor most of js graph work into its own folder nrwl/nx#15365 and attempt to use @nx-plus/vue's graph support on a codebase with that branch's code installed
  2. Note error.
@AgentEnder AgentEnder added the bug Something isn't working label Mar 27, 2023
@AgentEnder
Copy link
Author

Im going to close this out since v17 of nx has first party support for vue.

@AgentEnder AgentEnder closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant