Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call navigationBarsPadding on save Fab to add needed padding #1442

Merged
merged 2 commits into from
May 14, 2024
Merged

Call navigationBarsPadding on save Fab to add needed padding #1442

merged 2 commits into from
May 14, 2024

Conversation

eyedol
Copy link
Contributor

@eyedol eyedol commented May 13, 2024

Fixes #1357

Description

Before After
Before with the issue After with the issue
Before with the issue After with the issue

ZacSweers
ZacSweers approved these changes May 13, 2024
View reviewed changes
Copy link
Owner

@ZacSweers ZacSweers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ZacSweers ZacSweers merged commit 029ab9f into ZacSweers:main May 14, 2024
2 checks passed
@eyedol eyedol deleted the e/fabWindowInsetsFix branch May 14, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacSweers ZacSweers ZacSweers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAB in order services doesn't respect window insets in non-gesture nav
2 participants
@eyedol @ZacSweers