Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: comments in the manifest.toml are generating errors #2381

Closed
OniriCorpe opened this issue Apr 26, 2024 · 1 comment
Closed

CI: comments in the manifest.toml are generating errors #2381

OniriCorpe opened this issue Apr 26, 2024 · 1 comment
Labels
🚦 CI 👾 bug Something isn't working

Comments

@OniriCorpe
Copy link
Member

Describe the bug

if a manifest.toml have comments

# like this
[upstream] # or like this

the CI will generate errors before each test:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: '#'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: 'or'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: 'like'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: 'this'

To reproduce

put any comment in a manifest.toml and launch CI tests

Expected behavior

CI ignores manifest.toml comments

Logs

for example with this manifest.toml: https://github.com/YunoHost-Apps/pyinventory_ynh/blob/a6860459fb7bb8beb59b907e829663705f20f80d/manifest.toml

Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: '#'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: '__DEFAULT_FROM_EMAIL__'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: '#'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: '__ADMIN_EMAIL__'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: '#'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: '__DEBUG_ENABLED__'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: 'will'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: 'be'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: 'set'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: 'to'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: '"0"'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: 'or'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: '"1"'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: 'string'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: '#'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
KeyError: '__LOG_LEVEL__'
@OniriCorpe OniriCorpe added 👾 bug Something isn't working 🚦 CI labels Apr 26, 2024
@alexAubin
Copy link
Member

Fixed via YunoHost/package_check@aaca713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚦 CI 👾 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants