Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GB country code not supported #51

Open
2 of 3 tasks
sebastian-raubach opened this issue Jun 29, 2021 · 2 comments
Open
2 of 3 tasks

GB country code not supported #51

sebastian-raubach opened this issue Jun 29, 2021 · 2 comments

Comments

@sebastian-raubach
Copy link

sebastian-raubach commented Jun 29, 2021

It seems that you have individual codes for Scotland, England, Wales and Northern Ireland, which is nice, but the overall "United Kingdom of Great Britain and Northern Ireland" country code you're using is GB-UKM or rather the overall code for GB doesn't seem to be supported as listed under ISO 3166-1 alpha-2, see here: https://www.iban.com/country-codes

Please check all that apply

  • visual bug
  • functional bug
  • able to consistently reproduce

Expected Behavior

Using GB as the country code should result in the United Kingdom of Great Britain and Northern Ireland flag to be shown.

Current Behavior

Currently, using GB-UKM is the closest match.

Possible Solution

Change the country code to reflect the ISO standard.

Steps to Reproduce

1 Go here: https://flagpack.xyz/docs/flag-index/
2 Search for GB
3 Find GB-* instead of GB.

Context

I'm getting the country codes from a database according to the ISO standard. Therefore a specific hack for GB isn't something that I'd want to add.

Your Environment

  • Version used: 1.1.2
  • Browser Name and version: Chrome 91.0.4472.114
  • Operating System and version (desktop or mobile): Windows
@williamoverton
Copy link

In addition the Alpha 3 variant GBR is also not supported.

@daoneandonly
Copy link
Contributor

daoneandonly commented Jul 7, 2021

Using GBR-UKM and it's variants were our solution to both support the flag for United Kingdom aswell as England, Scotland, Wales and Northern Ireland. These are part of the ISO 3166 subset, ISO 3166-2:GB which we are planning to continue to support in our release of Flagpack. However I do concede that given our ISO 3166 policy we should definitely support both the ISO 3166 alongside the 3166-2:GB to cover all bases. This is especially true now that we're working on having Flagpack treeshakable. You can expect these changes to be part of the next major release of Flagpack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants