Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: check what PHPMD checks and if there are replacement sniffs #228

Open
jrfnl opened this issue Oct 7, 2020 · 2 comments
Open

Task: check what PHPMD checks and if there are replacement sniffs #228

jrfnl opened this issue Oct 7, 2020 · 2 comments

Comments

@jrfnl
Copy link
Collaborator

jrfnl commented Oct 7, 2020

Via:

Some PHPMD checks used to be run via CodeClimate. Now CodeClimate has been turned off, these are no longer run.

A number of things which PHPMD checked, can (also) be checked via sniffs.

It should be inventoried:

  • Which checks in PHPMD were considered useful.
  • If there are sniffs available for the same either in PHPCS itself or in external sniff libraries.

From the Slack conversations:

"At some points codeclimate made me think more about my code. Complexity of methods is one of those. Not using else-statement. Maybe we should communicate that kind of principles as much as possible "

@jrfnl
Copy link
Collaborator Author

jrfnl commented Sep 22, 2023

Blocked as this needs a list of checks which the devs found useful from PHPMD before a search can be done for similar sniffs.

@jrfnl
Copy link
Collaborator Author

jrfnl commented Sep 22, 2023

List of checks in PHPMD: https://phpmd.org/rules/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant