Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused translations #21386

Merged
merged 2 commits into from
May 27, 2024
Merged

Remove unused translations #21386

merged 2 commits into from
May 27, 2024

Conversation

thijsoo
Copy link
Contributor

@thijsoo thijsoo commented May 16, 2024 •
edited by leonidasmi

Context

  • This removes a couple of unused array keys.

Summary

This PR can be summarized in the following changelog entry:

  • Removes some unused translation information from our script data.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • There should be no impact. But it is good to smoke test all editors to see that there are no sudden console errors.
  • The smoke test should also happen in a language other than English and particularly check the translations in the Yoast metabox and even more specifically in the content analysis.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label May 16, 2024
@thijsoo thijsoo linked an issue May 16, 2024 that may be closed by this pull request
Remove unused translation script data #21379
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build acc074d8f2e3860de8bbefefe3c8a38a8221b019

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 52.65%
Totals Coverage Status
Change from base Build 5c69bf7f9e9b2722313b5f23207ead0be6f1bba7: 0.01%
Covered Lines: 28307
Relevant Lines: 54380
💛 - Coveralls

@leonidasmi leonidasmi added this to the feature/plugin-fixes milestone May 27, 2024
leonidasmi
leonidasmi approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@leonidasmi leonidasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + impact check is 👍

@leonidasmi leonidasmi merged commit 8e57e9d into feature/plugin-fixes May 27, 2024
23 checks passed
@leonidasmi leonidasmi deleted the 21379-remove-unused-translation-script-data branch May 27, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonidasmi leonidasmi leonidasmi approved these changes

Assignees
No one assigned
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Milestone
22.9
Development

Successfully merging this pull request may close these issues.

Remove unused translation script data
4 participants
@thijsoo @coveralls @leonidasmi @enricobattocchi