From 0b7a584d36db1516ce8a43ca8aa1cbb980f89c12 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Dufraisse?=
 <jeremy.dufraisse-info@orange.fr>
Date: Tue, 14 Dec 2021 09:23:18 +0100
Subject: [PATCH] fix(YesWiki/Href): escape params via urlencode to prevent XSS

---
 includes/YesWiki.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/includes/YesWiki.php b/includes/YesWiki.php
index cba4a2db4..bb61fe555 100755
--- a/includes/YesWiki.php
+++ b/includes/YesWiki.php
@@ -418,7 +418,7 @@ public function Href($method = null, $tag = null, $params = null, $htmlspchars =
                 $paramsArray = [];
                 foreach ($params as $key => $value) {
                     if ($value) {
-                        $paramsArray[] = "$key=$value";
+                        $paramsArray[] = "$key=".urlencode($value);
                     }
                 };
                 if (count($paramsArray)>0) {
@@ -1429,7 +1429,7 @@ public function replaceRecursivelyIndexedArrays(&$array1, &$array2)
         foreach ($array2 as $key => $val) {
             if (is_array($val)) {
                 if (!$this->isAssocArray($val)) {
-                    if(!isset($array1[$key]) || $array1[$key] != $val) {
+                    if (!isset($array1[$key]) || $array1[$key] != $val) {
                         $array1[$key] = $val;
                     }
                 } else {