Inconsistency between EVHTP_BUILD_SHARED and BUILD_SHARED_LIBS CMake options

[schmittlauch]

Details

While trying to build the libevhtp shared libraries, I discovered that the widely-documented (e.g. by Seafile) cmake flag EVHTP_BUILD_SHARED does not work anymore. Examining the CMakeLists.txt, I discovered that the flag BUILD_SHARED_LIBS has to be used.

There are two problems with that change:

1. This change has been done silently and isn't mentioned in the changelog.
2. The message indicating which build flags are activated still uses EVHTP_BUILD_SHARED instead of BUILD_SHARED_LIBS.

Thus I conclude that the flag change has been done accidentally.

Steps or code to reproduce the problem.

Build libevhtp with 2 different configuration variants and examine whether shared library files have been created:

variant 1: cmake -DEVHTP_BUILD_SHARED=ON .
result: shared library not build

variant 2: cmake -DBUILD_SHARED_LIBS=ON .
result: shared library is built

[vincentbernat]

This was changed in #79 by @isaachier. Maybe it would be possible to make EVHTP_BUILD_SHARED set BUILD_SHARED_LIBS as well?

[schmittlauch]

bump