Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search is NOT shown when runs it locally. #11

Open
JeffreyZZ opened this issue Oct 1, 2022 · 9 comments
Open

Search is NOT shown when runs it locally. #11

JeffreyZZ opened this issue Oct 1, 2022 · 9 comments

Comments

@JeffreyZZ
Copy link

JeffreyZZ commented Oct 1, 2022

image

Here is the header displayed while I ran this project on my local machine, as you can see that the search bar is missing and the header is NOT well lay out. Could you please help take a look?

@Yawan-1
Copy link
Owner

Yawan-1 commented Oct 2, 2022

Hello @JeffreyZZ , I have seen this and...

Long story short... The CSS I used in header is stack over flow's production CSS inserted like <link rel="stylesheet" href="xyz.stackoverflow"> and When they changed or updated their style then my stack over flow clone project styling also broke, Because they might have changed CSS class's names or styling. That's why you're seeing this broken style, But I have to stick to a separate non-production CSS so it won't break in future, and I will fix this as soon as possible.

Thanks for pointing out. Any other issues ?

@svanberg90
Copy link

Hello @Yawan-1
Have you seen into the use of non-production CSS for this project?

@Yawan-1
Copy link
Owner

Yawan-1 commented Jan 27, 2023

Hi @svanberg90 , I didn't understand what you are trying to ask. Can you explain in brief ?

@Yawan-1 Yawan-1 pinned this issue Jan 27, 2023
@svanberg90
Copy link

Hi @Yawan-1
If you look at the original post from JeffreyZZ where he ask why the layout you get when you run the project via manage.py runserver looks odd.
You mention in the post below that it has to do with stack over flow's production CSS.
Is there some way to fix this with a non-production CSS? You mentioned that you would look into such a solution

@Yawan-1
Copy link
Owner

Yawan-1 commented Jan 27, 2023

Yes, @svanberg90 There is a fix for this problem by sticking with a specific version of the CSS or by using Stackoverflow's Stacks it allow users to use site's design and components (like icons, themes, colors, model popups, etc.).

In short, There are two ways to fix this -

  1. We store stackoverflow's current CSS and serve from the django site itself (or from aws). In this option, we won't have to link stackoverflow's updating CSS but saved CSS will be used in production and It won't break whenever stackoverflow releases a new version of their CSS or whenever change their design.

  2. Second option is use to stacks, But It will take time, because We will have to replace and rename every class and every for loop component.

Note: Method 1 will use stackoverflow's production CSS which stackoverflow doesn't allow easily. They don't allow users to copy their production CSS

@svanberg90
Copy link

So maybe the way to go is to develop a new design, that dont use Stack css?

@Yawan-1
Copy link
Owner

Yawan-1 commented Jan 28, 2023

Yes and No, but why not to use Stack's CSS because it will take so much time to redesign class names and ids. And We will have to design a completly different layout which also take so much time to change the whole design.

Redesign the whole site < Use stacks . (on Time Basis).

I'd love to hear your opinions on this.

@svanberg90
Copy link

I see. I think the best solution would be to store stackoverflow's current CSS and serve from the django site. How difficult will it be to obtain the current css? And calibrate the page against the new css?

@Yawan-1
Copy link
Owner

Yawan-1 commented Feb 1, 2023

Sorry for late reply @svanberg90 , Yeah It is also good option. It won't be any difficult because mainly Header's CSS is the only style that is badly broken, so the main focus is to fix Header first.

And One more thing... Stackoverflow may also complain about using their production CSS (again). But We are good as long as we do not use it in live production website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants