Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go install github.com/Yash-Handa/logo-ls@latest fails #26

Open
brumhard opened this issue Jun 16, 2021 · 4 comments
Open

go install github.com/Yash-Handa/logo-ls@latest fails #26

brumhard opened this issue Jun 16, 2021 · 4 comments

Comments

@brumhard
Copy link

Hi there,

So I was trying to install logo-ls on my machine.
Since go1.16 go install <package>@latest is the default why to install go tools from a remote repo (see here).
When trying to do that with your project I get the following error:

❯ go install github.com/Yash-Handa/logo-ls@latest
go: downloading github.com/Yash-Handa/logo-ls v1.3.7
go install github.com/Yash-Handa/logo-ls@latest: create zip: testdata/logo-ls-a.snap: case-insensitive file name collision: "testdata/logo-ls-A.snap" and "testdata/logo-ls-a.snap"
testdata/logo-ls-r.snap: case-insensitive file name collision: "testdata/logo-ls-R.snap" and "testdata/logo-ls-r.snap"

I guess the issue comes from zip not being case sensitive. It would be great if you could rename the test files to allow the go install way since that is much easier than cloning & building manually as long as homebrew support is not there.

@brumhard
Copy link
Author

Also I couldn't even clone the repo properly on mac, since the file name collisions lead to an error. I guess that is only working on linux then.

@brumhard
Copy link
Author

I've created a fork to enable the go install for me. You can check it out with go install github.com/brumhard/logo-ls@0d88fb0b986e5a65eb65af14a79c52d8631e31c6 (since latest does not work without a new tag).
I had to add some code to fix the tests for mac. I'd be happy to contribute that back to your repo with a PR if you accept it.

@wasi-master
Copy link

Same issue here

@brumhard
Copy link
Author

@wasi-master yeah well sadly @Yash-Handa hasn't replied so I guess this won't be fixed anymore 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants