New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor bug in loss logging #71

Open

kuangdai opened this issue Jun 29, 2021 · 1 comment

kuangdai commented Jun 29, 2021

Line 109 in disvae/models/losses.py:

if not is_train or self.n_train_steps % self.record_loss_every == 1:

This does not work when self.record_loss_every is 1 (recording all mini-batches).

Fix:

if not is_train or (self.n_train_steps - 1) % self.record_loss_every == 0:

The text was updated successfully, but these errors were encountered:

Owner

YannDubs commented Jul 5, 2023

Ohh I somehow I missed that...
Thanks, if you send a PR I'd be happy to merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment