Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments missing #661

Open
YamatoSecurity opened this issue May 3, 2024 · 0 comments
Open

Comments missing #661

YamatoSecurity opened this issue May 3, 2024 · 0 comments
Assignees
@fukusuket
Labels
invalid This doesn't seem right low priority

Comments

@YamatoSecurity
Copy link
Collaborator

Screenshot 2024-05-03 at 08 12 10

On the left are our converted rule and the right has the original sigma rule. There seems to be a missing comment: Note: In the case of...
@fukusuket Whenever you have time, could you see if you can keep these comments as well?

Also, - 'ping' gets converted to - ping which is still valid YAML so is no problem, but would like to still keep the single quotes intact if it is not difficult to do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fukusuket fukusuket

Labels
invalid This doesn't seem right low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fukusuket @YamatoSecurity