Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space is double-escaped when submitting custom shorturl keyword #3698

Open
5 tasks done
dgw opened this issue Dec 30, 2023 · 0 comments
Open
5 tasks done

Space is double-escaped when submitting custom shorturl keyword #3698

dgw opened this issue Dec 30, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@dgw
Copy link
Member

dgw commented Dec 30, 2023

Code of Conduct

Submission validity

  • This is not a personal support request, that should be posted on discussions community.
  • I checked current issues and this request isn't a duplicate of an existing issue, opened or closed.

Self troubleshooting

Version

1.9.2

Description

When using a simple custom plugin such as shown in #3694 to allow (%20) in shorturl keywords, it is still not possible to create a custom keyword containing via the admin panel.

As submitted to the admin-ajax.php endpoint, the custom keyword (e.g. some space) appears to be double-escaped as some%2520space in the parameters sent. This leads the backend to create a shorturl with the incorrect keyword some20space.

Expectation

The frontend should only escape the keyword parameter containing a space once (some%20space), and the backend should then create the keyword some space (assuming that has been added to the shorturl charset by a plugin).

Reproduction steps

No response

Context

No response

@dgw dgw added the bug Something isn't working label Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant