Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice overlaps with header logo in admin panel #3578

Open
5 tasks done
dgw opened this issue Jun 5, 2023 · 1 comment
Open
5 tasks done

Notice overlaps with header logo in admin panel #3578

dgw opened this issue Jun 5, 2023 · 1 comment
Labels
admin panel bug Something isn't working

Comments

@dgw
Copy link
Member

dgw commented Jun 5, 2023

Code of Conduct

Submission validity

  • This is not a personal support request, that should be posted on discussions community.
  • I checked current issues and this request isn't a duplicate of an existing issue, opened or closed.

Self troubleshooting

Version

1.9.2

Description

When e.g. (de)activating a plugin, the div.notice overlaps with the header YOURLS logo:

image

Expectation

No response

Reproduction steps

  1. Log into admin panel
  2. Go to Manage Plugins
  3. Click "Activate" or "Deactivate" for one of the plugins available

Context

A quick fix for this is to add max-height: 4.5em; to the #yourls-logo style rules.

There might be a better approach, though. The number of items in the menu can vary depending on which plugins are active and which page of the admin panel the user's on.

Thanks to @Yuuki2012 for pointing this out, and letting me test CSS tweaks on their instance.

@dgw dgw added bug Something isn't working admin panel labels Jun 5, 2023
@dgw
Copy link
Member Author

dgw commented Jun 6, 2023

Another screenshot from @Yuuki2012 showing this also happens on stat pages (/keyword+):

image

Not making a separate issue, because whatever CSS change fixes the problem on the plugins page will likely also fix this. (Both have the same root cause: The logo lives in a floated element that the regular block elements don't clear.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin panel bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant