This repository has been archived by the owner on May 25, 2021. It is now read-only.
ICS calendar feature #468
Closed
ICS calendar feature #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bad-Science
reviewed
Jul 11, 2019
| @@ -38,7 +38,8 @@ services: | |||
| - "4200:4200" | |||
| volumes: | |||
| - "./web/src:/usr/src/app/src" | |||
| command: "ng build --watch" | |||
| - "./web/npm-cache:/root/.npm" | |||
There was a problem hiding this comment.
What's the reason for this change?
Bad-Science
reviewed
Jul 11, 2019
| COPY ./src $APP_DIR | ||
|
|
||
| VOLUME /usr/src/npm-cache | ||
| RUN npm install --depth 0 |
There was a problem hiding this comment.
This is problematic. The dependencies should be installed before the source is copied. Otherwise, the image has to be entirely rebuilt for every code change.
|
@sjhuang26 Thanks for the PR! A few things:
|
Bad-Science
reviewed
Jul 11, 2019
| "npm": "^5.4.2", | ||
| "rxjs": "^6.5.2", | ||
| "rxjs-compat": "^6.5.2", | ||
| "typings": "^2.1.1", | ||
| "web-animations-js": "^2.3.1", | ||
| "yacs-api-client": "^1.0.0-beta.11", | ||
| "zone.js": "^0.8.29" | ||
| "zone.js": "^0.8.29", | ||
| "lodash": "^4.17.11", |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #464.
Manually copied in an external library, because of dependency issues.