Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENUM] OAM/Sprite RAM format is not formatted properly in all Disassembled files #3

Open
TheRealHamtaro126 opened this issue Apr 8, 2018 · 2 comments
Labels
formatting Disassembly formatting changes

Comments

@TheRealHamtaro126
Copy link

This is a problem plaguing this and the SMB3 disassembly, of which is a big formatting issue concerning the Sprite OAM format... I've seen lots of labling, for example, Instead of:

STA Sprite_X_Position+8,y

It uses:

STA SpriteDMAArea+$B,y

This can be a very big pain, Soooo... Can this please be fixed?

@Xkeeper0
Copy link
Owner

Xkeeper0 commented Apr 9, 2018

in FUTURE I might just replace this with a macro, if possible, but we'll see.

@Xkeeper0 Xkeeper0 added the formatting Disassembly formatting changes label Apr 9, 2018
@Xkeeper0
Copy link
Owner

I've been looking into this; I don't think any sort of en-masse replace is possible, but doing something on a smaller scale might be possible. The hard part is, for the time being, determining when the game is referencing a specific portion of sprites versus an actual memory address -- e.g. "sprite y position + (0, 4, 8...)" or "sprite area + (8, 9, 10...)". In a case-by-case basis it might be doable, though.

pepperpow added a commit to pepperpow/smb2 that referenced this issue Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatting Disassembly formatting changes
Projects
None yet
Development

No branches or pull requests

2 participants