Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The request package used by Node 4.3.0 is depreciated #659

Closed
aakashbhatiaaccenture opened this issue Jan 10, 2024 · 6 comments
Closed

The request package used by Node 4.3.0 is depreciated #659

aakashbhatiaaccenture opened this issue Jan 10, 2024 · 6 comments
Assignees

Comments

@aakashbhatiaaccenture
Copy link

SDK you're using (please complete the following information):

  • Version [e.g. 4.37.0]

Describe the bug
xero-node >=4.0.0-alpha.1 depends on vulnerable versions of request. The request package itself is depreciated.

To Reproduce
Steps to reproduce the behavior:

  1. Install xero-node >= 4.0.0 using npm
  2. Run 'npm audit'
  3. See the vulnerability listed

Expected behavior
It should not make use of the depreciated package. Instead it could one the following listed packages: request/request#3143

Copy link

PETOSS-381

Copy link

Thanks for raising an issue, a ticket has been created to track your request

@AndrewLugg
Copy link

They have known about this for over a year, and not seeming to care. I feel this package is unmaintained. They are updating the xero api endpoints, but not maintaining any security updates.

@sangeet-joy-tw sangeet-joy-tw self-assigned this Feb 2, 2024
@manishT72
Copy link
Contributor

Apologies for the delay. We have removed direct dependencies on request module in version 5.0.0. We will soon remove it from other nested package dependencies.

@aakashbhatiaaccenture
Copy link
Author

Apologies for the delay. We have removed direct dependencies on request module in version 5.0.0. We will soon remove it from other nested package dependencies.

Thanks very much, really appreciate it

@sangeet-joy-tw
Copy link
Contributor

this issue is fixed in latest version of xero-node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants