diff --git a/Builds/CMake/RippledCore.cmake b/Builds/CMake/RippledCore.cmake index cc3441af5..9a211ef9b 100644 --- a/Builds/CMake/RippledCore.cmake +++ b/Builds/CMake/RippledCore.cmake @@ -433,13 +433,17 @@ target_sources (rippled PRIVATE src/ripple/app/tx/impl/CancelOffer.cpp src/ripple/app/tx/impl/CashCheck.cpp src/ripple/app/tx/impl/Change.cpp + src/ripple/app/tx/impl/ClaimReward.cpp src/ripple/app/tx/impl/CreateCheck.cpp src/ripple/app/tx/impl/CreateOffer.cpp src/ripple/app/tx/impl/CreateTicket.cpp src/ripple/app/tx/impl/DeleteAccount.cpp src/ripple/app/tx/impl/DepositPreauth.cpp src/ripple/app/tx/impl/Escrow.cpp + src/ripple/app/tx/impl/GenesisMint.cpp + src/ripple/app/tx/impl/Import.cpp src/ripple/app/tx/impl/InvariantCheck.cpp + src/ripple/app/tx/impl/Invoke.cpp src/ripple/app/tx/impl/NFTokenAcceptOffer.cpp src/ripple/app/tx/impl/NFTokenBurn.cpp src/ripple/app/tx/impl/NFTokenCancelOffer.cpp @@ -448,14 +452,10 @@ target_sources (rippled PRIVATE src/ripple/app/tx/impl/OfferStream.cpp src/ripple/app/tx/impl/PayChan.cpp src/ripple/app/tx/impl/Payment.cpp + src/ripple/app/tx/impl/Remit.cpp src/ripple/app/tx/impl/SetAccount.cpp - src/ripple/app/tx/impl/SetRegularKey.cpp src/ripple/app/tx/impl/SetHook.cpp - src/ripple/app/tx/impl/ClaimReward.cpp - src/ripple/app/tx/impl/GenesisMint.cpp - src/ripple/app/tx/impl/Import.cpp - src/ripple/app/tx/impl/Invoke.cpp - src/ripple/app/tx/impl/Remit.cpp + src/ripple/app/tx/impl/SetRegularKey.cpp src/ripple/app/tx/impl/SetSignerList.cpp src/ripple/app/tx/impl/SetTrust.cpp src/ripple/app/tx/impl/SignerEntries.cpp diff --git a/src/ripple/app/hook/impl/applyHook.cpp b/src/ripple/app/hook/impl/applyHook.cpp index 0b18e6a8d..bf5c9f160 100644 --- a/src/ripple/app/hook/impl/applyHook.cpp +++ b/src/ripple/app/hook/impl/applyHook.cpp @@ -1,12 +1,17 @@ #include #include #include +#include #include #include #include +#include +#include #include #include #include +#include +#include #include #include #include diff --git a/src/ripple/app/misc/NegativeUNLVote.cpp b/src/ripple/app/misc/NegativeUNLVote.cpp index 8343d4774..cd964ac6c 100644 --- a/src/ripple/app/misc/NegativeUNLVote.cpp +++ b/src/ripple/app/misc/NegativeUNLVote.cpp @@ -19,6 +19,7 @@ #include #include +#include #include namespace ripple { diff --git a/src/ripple/app/tx/impl/GenesisMint.cpp b/src/ripple/app/tx/impl/GenesisMint.cpp index dd2a10214..8b4dce3fb 100644 --- a/src/ripple/app/tx/impl/GenesisMint.cpp +++ b/src/ripple/app/tx/impl/GenesisMint.cpp @@ -23,6 +23,7 @@ #include #include #include +#include namespace ripple { diff --git a/src/ripple/app/tx/impl/Import.cpp b/src/ripple/app/tx/impl/Import.cpp index 28289870c..d40a80eba 100644 --- a/src/ripple/app/tx/impl/Import.cpp +++ b/src/ripple/app/tx/impl/Import.cpp @@ -24,12 +24,15 @@ #include #include #include +#include #include #include #include #include #include #include +#include +#include #include #include #include diff --git a/src/ripple/app/tx/impl/Invoke.cpp b/src/ripple/app/tx/impl/Invoke.cpp index 08a14bf32..387c6bae0 100644 --- a/src/ripple/app/tx/impl/Invoke.cpp +++ b/src/ripple/app/tx/impl/Invoke.cpp @@ -22,6 +22,7 @@ #include #include #include +#include namespace ripple { diff --git a/src/ripple/app/tx/impl/Remit.cpp b/src/ripple/app/tx/impl/Remit.cpp index c97c5e08b..084513e02 100644 --- a/src/ripple/app/tx/impl/Remit.cpp +++ b/src/ripple/app/tx/impl/Remit.cpp @@ -23,6 +23,9 @@ #include #include #include +#include +#include + namespace ripple { TxConsequences diff --git a/src/ripple/app/tx/impl/SetSignerList.cpp b/src/ripple/app/tx/impl/SetSignerList.cpp index 516bd63a1..87f69c51d 100644 --- a/src/ripple/app/tx/impl/SetSignerList.cpp +++ b/src/ripple/app/tx/impl/SetSignerList.cpp @@ -153,8 +153,10 @@ SetSignerList::preCompute() // NOTE: This way of computing the OwnerCount associated with a SignerList // is valid until the featureMultiSignReserve amendment passes. Once it // passes then just 1 OwnerCount is associated with a SignerList. -static int -signerCountBasedOwnerCountDelta(std::size_t entryCount, Rules const& rules) +int +SetSignerList::signerCountBasedOwnerCountDelta( + std::size_t entryCount, + Rules const& rules) { // We always compute the full change in OwnerCount, taking into account: // o The fact that we're adding/removing a SignerList and @@ -176,8 +178,8 @@ signerCountBasedOwnerCountDelta(std::size_t entryCount, Rules const& rules) return 2 + static_cast(entryCount); } -static TER -removeSignersFromLedger( +TER +SetSignerList::removeSignersFromLedger( Application& app, ApplyView& view, Keylet const& accountKeylet, diff --git a/src/ripple/app/tx/impl/SetSignerList.h b/src/ripple/app/tx/impl/SetSignerList.h index c80c6ba08..1b54e05d2 100644 --- a/src/ripple/app/tx/impl/SetSignerList.h +++ b/src/ripple/app/tx/impl/SetSignerList.h @@ -71,6 +71,18 @@ class SetSignerList : public Transactor AccountID const& account, beast::Journal j); + static TER + removeSignersFromLedger( + Application& app, + ApplyView& view, + Keylet const& accountKeylet, + Keylet const& ownerDirKeylet, + Keylet const& signerListKeylet, + beast::Journal j); + + static int + signerCountBasedOwnerCountDelta(std::size_t entryCount, Rules const& rules); + private: static void writeSignersToSLE( diff --git a/src/ripple/app/tx/impl/applySteps.cpp b/src/ripple/app/tx/impl/applySteps.cpp index b1708e0b1..ab2bf30ca 100644 --- a/src/ripple/app/tx/impl/applySteps.cpp +++ b/src/ripple/app/tx/impl/applySteps.cpp @@ -23,6 +23,7 @@ #include #include #include +#include #include #include #include @@ -39,12 +40,14 @@ #include #include #include +#include #include #include #include #include #include #include +#include namespace ripple { diff --git a/src/ripple/ledger/impl/ApplyViewBase.cpp b/src/ripple/ledger/impl/ApplyViewBase.cpp index dc98a35f7..1946f5c04 100644 --- a/src/ripple/ledger/impl/ApplyViewBase.cpp +++ b/src/ripple/ledger/impl/ApplyViewBase.cpp @@ -19,6 +19,7 @@ #include #include +#include namespace ripple { namespace detail { diff --git a/src/ripple/rpc/handlers/ServerInfo.cpp b/src/ripple/rpc/handlers/ServerInfo.cpp index 03850b60e..5009be739 100644 --- a/src/ripple/rpc/handlers/ServerInfo.cpp +++ b/src/ripple/rpc/handlers/ServerInfo.cpp @@ -19,6 +19,7 @@ #include #include +#include #include #include #include diff --git a/src/test/app/ClaimReward_test.cpp b/src/test/app/ClaimReward_test.cpp index 9581c98a9..85a6ba62e 100644 --- a/src/test/app/ClaimReward_test.cpp +++ b/src/test/app/ClaimReward_test.cpp @@ -17,7 +17,9 @@ */ //============================================================================== +#include #include +#include #include namespace ripple { diff --git a/src/test/app/GenesisMint_test.cpp b/src/test/app/GenesisMint_test.cpp index 3abcf0c85..9904f3715 100644 --- a/src/test/app/GenesisMint_test.cpp +++ b/src/test/app/GenesisMint_test.cpp @@ -15,8 +15,8 @@ */ //============================================================================== -#include #include +#include #include #include @@ -94,7 +94,7 @@ struct GenesisMint_test : public beast::unit_test::suite using namespace jtx; using namespace std::literals::chrono_literals; - Env env{*this, envconfig(), features, nullptr}; + Env env{*this, envconfig(), features}; auto const alice = Account("alice"); auto const bob = Account("bob"); auto const invoker = Account("invoker"); @@ -133,11 +133,7 @@ struct GenesisMint_test : public beast::unit_test::suite using namespace jtx; using namespace std::literals::chrono_literals; - Env env{*this, envconfig(), features, nullptr}; - // Env env{*this, envconfig(), features, nullptr, - // // beast::severities::kWarning - // beast::severities::kTrace - // }; + Env env{*this, envconfig(), features}; auto const alice = Account("alice"); auto const bob = Account("bob"); auto const invoker = Account("invoker"); @@ -639,7 +635,7 @@ struct GenesisMint_test : public beast::unit_test::suite using namespace jtx; using namespace std::literals::chrono_literals; - Env env{*this, envconfig(), features, nullptr}; + Env env{*this, envconfig(), features}; auto const alice = Account("alice"); auto const bob = Account("bob"); env.fund(XRP(10000), alice, bob); @@ -661,7 +657,7 @@ struct GenesisMint_test : public beast::unit_test::suite using namespace jtx; using namespace std::literals::chrono_literals; - Env env{*this, envconfig(), features, nullptr}; + Env env{*this, envconfig(), features}; auto const alice = Account("alice"); auto const bob = Account("bob"); env.fund(XRP(10000), alice, bob); diff --git a/src/test/app/Invoke_test.cpp b/src/test/app/Invoke_test.cpp index 20ffd796c..06bc45a3f 100644 --- a/src/test/app/Invoke_test.cpp +++ b/src/test/app/Invoke_test.cpp @@ -17,6 +17,7 @@ */ //============================================================================== +#include #include namespace ripple { diff --git a/src/test/app/Remit_test.cpp b/src/test/app/Remit_test.cpp index d71b4091e..ac527c9db 100644 --- a/src/test/app/Remit_test.cpp +++ b/src/test/app/Remit_test.cpp @@ -2132,7 +2132,6 @@ struct Remit_test : public beast::unit_test::suite auto const delta = USD(100); env(remit::remit(alice, bob), remit::amts({delta})); env.close(); - auto xferRate = transferRate(*env.current(), gw); auto const postAlice = env.balance(alice, USD.issue()); BEAST_EXPECT(env.balance(bob, USD.issue()) == preBob + delta); BEAST_EXPECT(to_string(postAlice.value()) == tc.result); diff --git a/src/test/app/SetHookTSH_test.cpp b/src/test/app/SetHookTSH_test.cpp index 3e209c0fb..ec45edd60 100644 --- a/src/test/app/SetHookTSH_test.cpp +++ b/src/test/app/SetHookTSH_test.cpp @@ -18,6 +18,7 @@ */ //============================================================================== +#include #include #include #include @@ -31,6 +32,13 @@ namespace ripple { namespace test { +#define BEAST_REQUIRE(x) \ + { \ + BEAST_EXPECT(!!(x)); \ + if (!(x)) \ + return; \ + } + struct SetHookTSH_test : public beast::unit_test::suite { private: diff --git a/src/test/jtx/impl/acctdelete.cpp b/src/test/jtx/impl/acctdelete.cpp index f7d9aa9b6..ea104e22b 100644 --- a/src/test/jtx/impl/acctdelete.cpp +++ b/src/test/jtx/impl/acctdelete.cpp @@ -17,6 +17,7 @@ */ //============================================================================== +#include #include #include diff --git a/src/test/jtx/impl/escrow.cpp b/src/test/jtx/impl/escrow.cpp index 2fb1e22f1..ad41c8a5f 100644 --- a/src/test/jtx/impl/escrow.cpp +++ b/src/test/jtx/impl/escrow.cpp @@ -17,6 +17,7 @@ */ //============================================================================== +#include #include #include diff --git a/src/test/jtx/impl/network.cpp b/src/test/jtx/impl/network.cpp index ec5192068..e08976ca3 100644 --- a/src/test/jtx/impl/network.cpp +++ b/src/test/jtx/impl/network.cpp @@ -17,6 +17,7 @@ */ //============================================================================== +#include #include #include #include diff --git a/src/test/jtx/impl/paychan.cpp b/src/test/jtx/impl/paychan.cpp index da2ad3d38..50cbf209a 100644 --- a/src/test/jtx/impl/paychan.cpp +++ b/src/test/jtx/impl/paychan.cpp @@ -17,6 +17,7 @@ */ //============================================================================== +#include #include #include diff --git a/src/test/jtx/offer.h b/src/test/jtx/offer.h index 2ff9725ae..874f59722 100644 --- a/src/test/jtx/offer.h +++ b/src/test/jtx/offer.h @@ -23,6 +23,7 @@ #include #include #include +#include namespace ripple { namespace test { diff --git a/src/test/rpc/ServerDefinitions_test.cpp b/src/test/rpc/ServerDefinitions_test.cpp index fd9de6613..65e77d1a7 100644 --- a/src/test/rpc/ServerDefinitions_test.cpp +++ b/src/test/rpc/ServerDefinitions_test.cpp @@ -19,6 +19,7 @@ #include #include +#include #include #include #include