Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move project level settings to Project Settings Window #532

Open
FejZa opened this issue Apr 22, 2020 · 6 comments
Open

Move project level settings to Project Settings Window #532

FejZa opened this issue Apr 22, 2020 · 6 comments
Assignees
Labels
Feature Request FR Accepted Feature Request accepted, ready for development

Comments

@FejZa
Copy link
Contributor

FejZa commented Apr 22, 2020

XRTK - Mixed Reality Toolkit Change Request

Is your change request related to a problem? Please describe

XRTK currently puts its settings into Unity's Preferences window, which is
for editor preferences. XRTK's project level settings should move to the Project Settings
window.

How would you classify your suggestion

  • UI / UX

Describe the solution you'd like

Move XRTK project level settings into Project Settings window instead of Preferences.

Additional context

xrtk_preferences

@StephenHodgson
Copy link
Member

These settings are in the correct place.

Project level settings are for project specific things.

I could see the need to move the generated profile and start scene.

@Jarodshow weren't you working on something for this?

@FejZa
Copy link
Contributor Author

FejZa commented Apr 22, 2020

They are most definitely not. XRTK is almost by definition a project level tool. It brings no benefit to the editor in general that is not tied to a project. So I can't see how they are in the right place here.

@FejZa
Copy link
Contributor Author

FejZa commented Apr 22, 2020

For some of the above I guess one can argue they are editor prefernces, yes.

@StephenHodgson
Copy link
Member

I just didn't feel like there was enough to warrant two different menu screens.

I think @Jarodshow was working on an update to this window.

@StephenHodgson StephenHodgson added the FR Accepted Feature Request accepted, ready for development label Apr 26, 2020
@jshowacre
Copy link
Contributor

jshowacre commented Apr 26, 2020

This is all in the fix/editorprefs branch :)

@jshowacre
Copy link
Contributor

jshowacre commented Apr 26, 2020

I could see the need to move the generated profile and start scene.

This is in the project settings currently.
@FejZa feel free to push(or tell me) any additional settings you see fit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request FR Accepted Feature Request accepted, ready for development
Projects
None yet
Development

No branches or pull requests

3 participants